comphead commented on code in PR #7511: URL: https://github.com/apache/datafusion-comet/pull/7511#discussion_r4485577948
########## native/shuffle/src/spark_unsafe/row.rs: ########## @@ -369,7 +369,6 @@ pub(super) fn append_field( /// /// Unlike `append_struct_fields_field_major`, this function takes slices of row addresses, Review Comment: The doc comment on this function is now out of date, including the unchanged line above these two that calls it "a helper function for processing nested struct fields recursively". `append_struct_fields_field_major` no longer has its own field loop and calls this function for the top-level case too. Could the doc say that this is the single field-major implementation for both, and that the top-level caller builds the address, size and validity slices from the parent rows before calling it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
