alamb commented on code in PR #12456:
URL: https://github.com/apache/datafusion/pull/12456#discussion_r1759143664


##########
datafusion/core/src/datasource/physical_plan/parquet/opener.rs:
##########
@@ -41,21 +41,41 @@ use std::sync::Arc;
 
 /// Implements [`FileOpener`] for a parquet file
 pub(super) struct ParquetOpener {
+    /// Execution partition index
     pub partition_index: usize,
+    /// Column indexes in `table_schema` needed by the query

Review Comment:
   This in particular was unclear when @itsjunetime  and I read the code (were 
the indexes in terms of file_schema or table_schema?) and was the impetus for 
this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to