ole-baranov commented on PR #26190: URL: https://github.com/apache/datafusion/pull/26190#issuecomment-6678263833
> hi @ole-baranov, > > I added [required-feature protoc](https://github.com/apache/datafusion/pull/27153/commits/b1e1a620ed9e3eb0e732a9ba963b148f52fe08d5) in #27153 because of [adriangb/datafusion-benchmarking#49](https://github.com/adriangb/datafusion-benchmarking/pull/49) > > Here are the runs: > > [run 1](https://github.com/apache/datafusion/pull/27153#issuecomment-6676768093) > > ``` > group HEAD bench2-26190 > ----- ---- ------------ > consume_wide_read/100 1.00 32.1±0.24µs ? ?/sec 1.03 33.2±0.31µs ? ?/sec > consume_wide_read/1000 1.00 437.5±3.01µs ? ?/sec 1.03 449.1±3.30µs ? ?/sec > consume_wide_read/10000 1.00 5.2±0.02ms ? ?/sec 1.05 5.4±0.03ms ? ?/sec > ``` > > [run 2](https://github.com/apache/datafusion/pull/27153#issuecomment-6676948823) > > ``` > group HEAD bench2-26190 > ----- ---- ------------ > consume_wide_read/100 1.00 32.0±0.50µs ? ?/sec 1.03 33.0±0.09µs ? ?/sec > consume_wide_read/1000 1.00 437.0±1.84µs ? ?/sec 1.02 445.1±1.97µs ? ?/sec > consume_wide_read/10000 1.00 5.1±0.02ms ? ?/sec 1.05 5.4±0.02ms ? ?/sec > ``` > > Both show slightly slower performance. hi @kosiew ! It is possibly a tooling issue. Yesterday, I ran `critcmp` on different `criterion` runs, and it showed results just like yours. My problem was that I forgot to use the `--save-baseline` argument for the `criterion` run. Could you share the commands you used to run the tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
