alamb commented on code in PR #11827:
URL: https://github.com/apache/datafusion/pull/11827#discussion_r1759390202
##########
datafusion/functions-aggregate-common/src/aggregate/groups_accumulator.rs:
##########
@@ -348,6 +352,46 @@ impl GroupsAccumulator for GroupsAccumulatorAdapter {
fn size(&self) -> usize {
self.allocation_bytes
}
+
+ fn convert_to_state(
+ &self,
+ values: &[ArrayRef],
+ opt_filter: Option<&BooleanArray>,
+ ) -> Result<Vec<ArrayRef>> {
+ let num_rows = values[0].len();
+
+ // Each row has its respective group
+ let mut results = vec![];
+ for row_idx in 0..num_rows {
+ // Create the empty accumulator for converting
+ let mut converted_accumulator = (self.factory)()?;
Review Comment:
as a follow on PR I wonder if we could potentially to improve performance by
adding a `clear()` or `reset()` type function to each accumulator to avoid
having to create a new accumulator for each group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
