devanbenz commented on PR #27126: URL: https://github.com/apache/datafusion/pull/27126#issuecomment-6690544181
> Also if there is only a single input partition we don't poll the stream eagerly. My assumption is that this is correct , there is nothing to merge when there is a single input partition so we just pass the child stream through and just starts whenever the child stream starts. That being said whether the eagerness of the streams is a side-effect or an actual design choice is up in the air. I'll need to look more in to the different Join operators this weekend more as I'm not as intimately familiar with them as I would like to be to offer much in the way of good suggestions. What you brought up from the [HashJoinBuffering operator](https://github.com/apache/datafusion/pull/27126#issuecomment-6690446935) is interesting though. I'll take a peak when I have some time. Let me do some exploratory work and I'll get back to this PR :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
