alexanderbianchi commented on PR #27099: URL: https://github.com/apache/datafusion/pull/27099#issuecomment-6692257148
https://github.com/alexanderbianchi/datafusion/tree/codex/substrait-27099-regressions I pushed some tests here reproducing the bugs my bot found. 1. [Dictionary values — regression_struct_literal_dictionary_values](https://github.com/alexanderbianchi/datafusion/blob/786edb8e2a2c6bbe48b1c9eaa9c9dc0c71002ade/datafusion/substrait/tests/cases/roundtrip_logical_plan.rs#L2763) An empty list containing dictionary-encoded structs retains c0 instead of a, causing coalesce coercion to fail. 2. [Independent function arguments — regression_struct_literal_independent_function_arguments](https://github.com/alexanderbianchi/datafusion/blob/786edb8e2a2c6bbe48b1c9eaa9c9dc0c71002ade/datafusion/substrait/tests/cases/roundtrip_logical_plan.rs#L2823) named_struct renames an independent literal’s field, breaking subsequent access with “Field c0 not found in struct.” 3. [UNION input wrapped in LIMIT — regression_struct_literal_union_with_limit](https://github.com/alexanderbianchi/datafusion/blob/786edb8e2a2c6bbe48b1c9eaa9c9dc0c71002ade/datafusion/substrait/tests/cases/roundtrip_logical_plan.rs#L2867) A LIMIT hides the literal-producing projection, causing an unsupported cast from Struct<a> to Struct<c0>. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
