FreakingMind opened a new pull request, #7534: URL: https://github.com/apache/datafusion-comet/pull/7534
## Which issue does this PR close? Part of #6974 (step 1 only). ## Rationale for this change floor.rs tests the switch from i64 to i128 at the i64 limits, and scale 19, which skips the pow10 dispatch. ceil.rs has the same code paths but no such tests. ## What changes are included in this PR? Two tests copied from floor.rs. The expected values are different because ceil rounds the other way: 9223372036854.775807 becomes 9223372036855 instead of 9223372036854. ## How are these changes tested? Test-only change. To check that the tests catch real bugs, I temporarily broke ceil at i64::MAX, at i64::MIN and in the scale 19 fallback. Each time only the matching new test failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
