alamb commented on code in PR #27191:
URL: https://github.com/apache/datafusion/pull/27191#discussion_r4501617041
##########
datafusion/physical-expr/src/equivalence/properties/mod.rs:
##########
@@ -392,12 +392,27 @@ impl EquivalenceProperties {
.filter_map(|o| self.normalize_sort_exprs(o))
.collect();
if !normal_orderings.is_empty() {
+ // What the new orderings imply through known equalities.
`add_constants`
+ // and `add_equal_conditions` discover this too, and whether an
ordering
+ // is satisfied must not depend on which of them ran last. If it
cannot
+ // be derived, nothing is implied.
+ let implied: Vec<_> = normal_orderings
+ .iter()
+ .filter_map(|ordering| {
+ self.implied_ordering(&ordering[0], ordering[1..].iter())
+ .ok()
+ .flatten()
Review Comment:
I agree it would be good not to drop the errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
