sam-1112 commented on PR #5835: URL: https://github.com/apache/datafusion-comet/pull/5835#issuecomment-6708625058
<html><head></head><body><p>Thanks @comphead! I've addressed all five comments:</p> <ul> <li>Removed the dispatcher ConfigMatrix from both SHA-2 fixtures.</li> <li>Removed the duplicate STRING literal-width checks, retaining <code>128 + 128</code>, row-varying widths, BINARY inputs, NULLs, and the ANSI short-circuit regressions.</li> <li>Added <code>sha2_dynamic_bits</code> to <code>CometHashExpressionBenchmark</code> and removed the standalone benchmark. I used <code>pmod(c_int, 6) + 1</code> because the existing corpus includes negative integers, and <code>% 6 + 1</code> can produce an invalid zero index.</li> <li>Dropped the TimeType test, import, and class-comment changes from <code>CometHashExpressionSuite</code>.</li> <li>Reverted the unrelated documentation edits, keeping only the SHA-2 updates.</li> </ul> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
