snmvaughan opened a new pull request, #7564: URL: https://github.com/apache/datafusion-comet/pull/7564
## Which issue does this PR close? Closes #7563. ## Rationale for this change `COMET_BUILD_TIMESTAMP` always reports `2020-01-22T15:10:15Z`. git-commit-id-maven-plugin takes `git.build.time` from `project.build.outputTimestamp`, which the Apache parent POM pins for reproducible builds. So `comet-git-info.properties` has no time that tells builds apart. The commit time does, and because it's fixed per commit, builds stay reproducible. The plugin also formats its dates in the build machine's time zone, so the file differs between machines. ## What changes are included in this PR? - `spark/pom.xml`: include `git.commit.time` in `comet-git-info.properties`, and format the plugin's dates in UTC (`dateFormatTimeZone`). - `org.apache.comet` package object: add `COMET_COMMIT_TIMESTAMP`, read from `git.commit.time`. ## How are these changes tested? Ran the plugin's `revision` goal for the `spark` module with the JVM in `America/Los_Angeles`, before and after the change: - Before: `git.build.time=2020-01-22T07:10:15-08:00`, and no `git.commit.time`. - After: `git.build.time=2020-01-22T15:10:15Z`, and `git.commit.time` equal to the HEAD commit's time in UTC (`git log -1 --format=%cd` with `TZ=UTC`). `COMET_COMMIT_TIMESTAMP` follows the existing build-info constants, which have no tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
