laxmanmamididd commented on PR #7464: URL: https://github.com/apache/datafusion-comet/pull/7464#issuecomment-6711824892
fc3a4f2a1 closes a test-order race @sunchao reproduced on #7363. A close queued on the dispatcher's thread by one test could land after the next test reset the shared counters. `CometS3CredentialDispatcherTest` now waits for queued closes before each test resets and after each test, through a test-only `awaitQueuedClosesForTesting()`. Running the class 1,500 times in a row gave no failed runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
