marvelefe opened a new pull request, #27208:
URL: https://github.com/apache/datafusion/pull/27208

   > [!IMPORTANT]
   >
   > **Fork CI setup:** For pull requests from a fork to `main`, enable 
workflows in your fork's **Actions** tab before you push.
   > See the [fork CI setup 
guide](https://datafusion.apache.org/contributor-guide/#pull-requests-from-forks).
   
   ## Which issue does this PR close?
   
   - Closes #26645.
   
   ## Rationale for this change
   
   The `SanityCheckPlan` error for a pipeline-breaking operator on an unbounded
   input printed the operator with `{:?}`. For a `SortExec` that is a few
   thousand characters of properties and metrics, so the operator name and
   columns get buried. The other errors in the same file already print the plan
   as text.
   
   ## What changes are included in this PR?
   
   - Format the rejected operator with `displayable(input).one_line()` instead
     of `{:?}`, so it reads like `EXPLAIN`:
     `operator: SortExec: TopK(fetch=1), expr=[d@4 ASC NULLS LAST], 
preserve_partitioning=[false]`
   - Add a sqllogictest case covering the new message.
   
   ## What is the testing strategy for this PR?
   
   Added a `statement error` case in `ddl.slt` that runs a sorted `LIMIT` over
   an unbounded table and checks the exact message. The existing tests in
   `core/tests/physical_optimizer/sanity_checker.rs` still pass, since they
   match the message with a substring.
   
   ## Are there any user-facing changes?
   
   Yes, the error text is now readable. No API changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to