snmvaughan opened a new issue, #7563: URL: https://github.com/apache/datafusion-comet/issues/7563
### What is the problem the feature request solves? `COMET_BUILD_TIMESTAMP` in the `org.apache.comet` package object reads `git.build.time` from `comet-git-info.properties`. git-commit-id-maven-plugin takes `git.build.time` from `project.build.outputTimestamp`, which the Apache parent POM (version 23) pins to `2020-01-22T15:10:15Z` for reproducible builds. So every Comet build reports the same build time, and nothing in the file says when the code it was built from was committed. The plugin also formats its dates in the time zone of the machine that runs the build, so the file differs between machines. With the JVM in `America/Los_Angeles`, `git.build.time` reads `2020-01-22T07:10:15-08:00`. ### Describe the potential solution - Include `git.commit.time` in `comet-git-info.properties`. It's fixed per commit, so builds stay reproducible. - Expose it as `COMET_COMMIT_TIMESTAMP`, next to `COMET_BUILD_TIMESTAMP`. - Set the plugin's `dateFormatTimeZone` to `UTC`, so both dates are written the same way on every machine. ### Additional context None. ### Willingness to contribute I can contribute a fix for this feature independently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
