goingforstudying-ctrl commented on code in PR #2779:
URL:
https://github.com/apache/datafusion-ballista/pull/2779#discussion_r4489352526
##########
ballista/core/src/client_pool.rs:
##########
@@ -108,11 +113,21 @@ impl SharedClient {
self.client.clone()
}
+ /// Installs the hook the first [discard](Self::discard) runs. Discards
+ /// after the first do not run it again.
+ pub fn set_discard_hook(&self, hook: Box<dyn FnOnce() + Send + Sync>) {
Review Comment:
Done in f47631b. The doc now says the hook is intended for the pool that
created the connection and that callers borrowing the connection shouldn't
replace it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
