LucaCappelletti94 opened a new pull request, #2820:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2820

   I have fuzzed the new statements I added against postgres and it did not 
leave me the time to get a coffee.
   
   PostgreSQL 18 made virtual generated columns the default, and `GENERATED 
ALWAYS AS (expr)` now takes an optional `STORED` or `VIRTUAL` ([CREATE 
TABLE](https://www.postgresql.org/docs/18/sql-createtable.html)). 
`PostgreSqlDialect` still demanded `STORED`, so `CREATE TABLE p (a INT, g INT 
GENERATED ALWAYS AS (a) VIRTUAL)` failed with `Expected: STORED, found: 
VIRTUAL`. The `pg_dump` output for a virtual column omits the keyword and 
failed the same way.
   
   At least it is a rather small fix.
   
   Fixes #2407.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

  • [PR] PostgreSQL: Accept `VIRTUAL... LucaCappelletti94 (via GitHub) via github

Reply via email to