andygrove commented on PR #7504: URL: https://github.com/apache/datafusion-comet/pull/7504#issuecomment-6645716715
> Maybe I am beating a dead horse, but I still don't understand why we maintain this code path. It's not the default and it takes resources to maintain for a codepath that I still haven't seen a huge, justifiable win for. > > * [Native columnar-to-row conversion is much slower than the JVM implementation for small batches #5112](https://github.com/apache/datafusion-comet/issues/5112) > * [Revisit the case for native columnar-to-row? #4440](https://github.com/apache/datafusion-comet/issues/4440) > * [perf: optimize JVM columnar-to-row conversion #5496](https://github.com/apache/datafusion-comet/pull/5496) made the JVM path even faster, it seems. > > I would love to find a real workload that benefits from the native code that we're keeping around and finding bugs in. I agree. I'll take one more look at the implementation and then plan to remove. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
