zhangfengcdt commented on PR #7316: URL: https://github.com/apache/datafusion-comet/pull/7316#issuecomment-6644153350
> Reviewed [949f550](https://github.com/apache/datafusion-comet/commit/949f5502c118a716744f8991e3a82663aac04336) across five independent scopes, including the new merge from main. The filter merge preserves both the bounded input and session batch size. The operator-level split and revised fixtures address the previous window/input-size and NullPropagation coverage gaps. Two paths still overflow: a deterministic large scalar beneath a volatile expression, and a large scalar in a range-shuffle key. Both have executed Spark/default-batch/small-batch controls in the inline comments. CI (fork) currently requires contributor action. Thanks for the review again, @sunchao. It should be fixed now. The measurement now treats a column, volatile function or JVM UDF as a boundary and keeps counting the scalars beside it, so `concat(repeat('x', 262144), uuid())` is bounded without evaluating uuid() at plan time. I also added a fixture query and a CometNativeShuffleSuite test similar to the test cases you reported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
