shehabgamin opened a new pull request, #27226: URL: https://github.com/apache/datafusion/pull/27226
## Which issue does this PR close? - Closes #27225. ## Rationale for this change With two unbounded inputs, `JoinSelection` converts a null-aware hash join into a `SymmetricHashJoinExec`, which has no null-aware mode. `NOT IN` then runs as a plain anti join and can return wrong rows when NULLs are involved. ## What changes are included in this PR? `hash_join_convert_symmetric_subrule` now skips null-aware joins, so they stay `HashJoinExec`. ## What is the testing strategy for this PR? A new unit test in `datafusion/core/tests/physical_optimizer/join_selection.rs` builds a null-aware join over unbounded inputs and checks that it stays a null-aware `HashJoinExec`. The test fails without the fix. ## Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
