alamb commented on code in PR #27159: URL: https://github.com/apache/datafusion/pull/27159#discussion_r4506066582
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -759,6 +759,14 @@ SELECT approx_median(c12) FROM aggregate_test_100 statement error SELECT approx_median(c1) FROM aggregate_test_100 +# APPROX_MEDIAN ignores aggregate ORDER BY keys. They must not be interpreted Review Comment: Does it make sense to support ORDER BY that is just ignored? What do other systems (postgres?) do? I think it would be better to reject this query with a more specific message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
