alamb commented on issue #5492: URL: https://github.com/apache/datafusion/issues/5492#issuecomment-6723659014
> @alamb a question on rule 2 of https://github.com/apache/datafusion/issues/5492#issuecomment-6479090126: should an error-instead-of-wrong-result PR also be allowed to reject queries that return correct rows in a released version? I'm not sure that regression is acceptable here, so I'd prefer not to. I'd keep queries that work in the release working, and use an error instead of a semantic fix only for shapes that are wrong in the release or never worked, until the general framework lands. I agree -- we shouldn't be breaking queries that worked (and produced correct rows) in previous releases Changing queries to erorring when the returned incorrect rows in previous releases does seem like an improvement to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
