Goldloli opened a new pull request, #27242: URL: https://github.com/apache/datafusion/pull/27242
## Which issue does this PR close? - Part of #27239 (batch of files claimed in https://github.com/apache/datafusion/issues/27239#issuecomment-6722923926) ## Rationale for this change Per #27239: escaped-regex error checks on the `statement error` / `query error` line are hard to read and review. The plain-text form after `----` is exact and readable. ## What changes are included in this PR? Converts 39 error records in 7 files: | file | converted | kept as regex (on purpose) | |---|---|---| | test_files/errors.slt | 4 | 2 records whose regex ends with a `$` anchor | | test_files/table_functions.slt | 6 | — | | test_files/struct.slt | 4 | — | | test_files/subquery.slt | 5 | — | | test_files/group_by.slt | 5 | — | | test_files/math.slt | 11 | — | | test_files/ddl.slt | 4 | the wildcard local-path records (`.*`) | `set_variable.slt` from the claimed batch stays unchanged: its regexes match only the first part of the error on purpose (the actual errors carry additional `caused by` chains, e.g. `Error parsing 'abc' as bool\ncaused by\nExternal error: provided string was not `true` or `false``), so the escaped form is kept. ## What is the testing strategy for this PR? Ran the sqllogictest runner for each converted file before and after the change and compared the failure sets with unmodified `main`: ``` cargo test --test sqllogictests -- <file>.slt ``` All converted records pass. The pre-existing failures are identical to `main` (only shifted by the inserted lines): `errors.slt` (2 records, `main` fails the same way locally), `group_by.slt` (4 records), `ddl.slt` (1 record) — none of them are records touched by this PR. No Rust code was changed, so `cargo fmt` / `clippy` are unaffected (fmt run for completeness). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
