NoahKusaba commented on code in PR #2638: URL: https://github.com/apache/datafusion-ballista/pull/2638#discussion_r4507343316
########## integrations/iceberg/src/scheduler.rs: ########## @@ -0,0 +1,67 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Readies a separately deployed scheduler for Iceberg. + +use std::sync::Arc; + +use ballista_core::utils::default_session_builder; +use ballista_scheduler::config::SchedulerConfig; +use datafusion::catalog::CatalogProvider; + +use crate::{IcebergLogicalCodec, IcebergPhysicalCodec, register_iceberg}; + +/// Readies a [`SchedulerConfig`] for Iceberg. +pub trait SchedulerConfigExt { + /// Adds the Iceberg codecs after any codecs already set, and mounts + /// `catalogs` in each session, readied with [`register_iceberg`]. The + /// scheduler plans queries from Flight SQL clients itself, so they can + /// then query those catalogs. + fn with_iceberg<N: Into<String>>( + self, + catalogs: impl IntoIterator<Item = (N, Arc<dyn CatalogProvider>)>, + ) -> Self; +} + +impl SchedulerConfigExt for SchedulerConfig { + fn with_iceberg<N: Into<String>>( + mut self, + catalogs: impl IntoIterator<Item = (N, Arc<dyn CatalogProvider>)>, + ) -> Self { + let logical = IcebergLogicalCodec::after(self.override_logical_codec.take()); Review Comment: As far as I can tell there isn't an easy way to address this without an upstream change to ballista-core, I'll look into it as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
