tlfua commented on PR #7456: URL: https://github.com/apache/datafusion-comet/pull/7456#issuecomment-6616868361
Thanks for the review. I've pushed dc1559ce8 for the comments above. The PR description has the updated benchmark table and test list. On comparisons, you're right. `SELECT id, n < CAST(txt AS INT) FROM cmp` fails in Comet under ANSI where `n` is NULL and `txt` is malformed, while Spark returns NULL. `WHERE n = CAST(txt AS INT)` happened not to fail, since the inferred `isnotnull(n)` and the lazy `AND` skip the row first. I'd keep it out of this PR since it is already large, and opened https://github.com/apache/datafusion-comet/issues/7468 for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
