lakshaydevoo-arch commented on code in PR #27008:
URL: https://github.com/apache/datafusion/pull/27008#discussion_r4489841901
##########
datafusion/common/benches/with_hashes.rs:
##########
@@ -188,7 +218,21 @@ where
builder.append_non_null();
}
}
- builder.finish().expect("should be nulls in buffer")
+ builder.finish()
+}
+
+/// Returns `dict` with a new random null mask on its keys, where each key is
null
+/// with probability `null_density`. Any existing key nulls are replaced, and
the
+/// key and value buffers are shared rather than copied
+fn with_null_keys<K: ArrowDictionaryKeyType>(
Review Comment:
add_nulls now takes a density parameter and handles all these cases. the
runarray path is unchanged apart from passing the density.
##########
datafusion/common/benches/with_hashes.rs:
##########
@@ -188,7 +218,21 @@ where
builder.append_non_null();
}
}
- builder.finish().expect("should be nulls in buffer")
+ builder.finish()
+}
+
+/// Returns `dict` with a new random null mask on its keys, where each key is
null
+/// with probability `null_density`. Any existing key nulls are replaced, and
the
+/// key and value buffers are shared rather than copied
+fn with_null_keys<K: ArrowDictionaryKeyType>(
Review Comment:
removed `with_null_keys` completely since `add_nulls` now handles the
dictionary cases too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
