andygrove commented on PR #2813: URL: https://github.com/apache/datafusion-ballista/pull/2813#issuecomment-6730376249
Thanks for taking a look @milenkovicm! The Python changes are in there, they're just easy to miss. `client.py` has a small type hint change, and `ballista_pb2.py` and `ballista_pb2.pyi` are regenerated. GitHub collapses `ballista_pb2.py` because it's mostly one huge serialized descriptor line. I re-ran `python/dev/generate_proto.sh` against this branch and got identical output, and the stub check in CI passes too. On the bindings, the Python client only reads `executor_meta.host` and `executor_meta.port` from a job status location. `ExecutorEndpoint` keeps `id`, `host` and `port` at the same field numbers as the old `ExecutorMetadata` (1, 2 and 3) and reserves 4 to 6. So the job status wire format stays compatible for Python clients, and an older client can still talk to a newer scheduler and vice versa. The Python release tests pass on all three versions as well. I added a line about this to the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
