rluvaton opened a new pull request, #12474: URL: https://github.com/apache/datafusion/pull/12474
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #12472 ## Rationale for this change Support more operators ## What changes are included in this PR? Implement the Spark implementation for `greatest`: https://spark.apache.org/docs/latest/api/python/reference/pyspark.sql/api/pyspark.sql.functions.greatest.html ## Are these changes tested? I was not able to find where you put the functions test, the `coalesce` for example has only one test for the return type, I must missing something https://github.com/apache/datafusion/blob/7bd77477b3aa65d23fc096db140a08617ba2bd55/datafusion/functions/src/core/coalesce.rs#L142-L157 ## Are there any user-facing changes? Yes, I need to add documentation, but first check if this feature is desired -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
