LucaCappelletti94 commented on issue #2893: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2893#issuecomment-6744577466
Could you please provide links to your version and benchmarks over a corpus like the one I prepared in https://github.com/LucaCappelletti94/sql_ast_benchmark ? My focus at this time is to work further towards completing the AST support and resolving the many fuzzer-identified bugs, which would confound the bugs caused from any refactoring. The library still lacks a large amount of common syntax, which I believe has priority over speed since the library is not *that* slow at this time. Another critical correctness issue in the current crate, before speed or allocations are concerned, is the spans. At this time the vast majority of them is plainly wrong, and will need to be addressed before refactorings for the same reason I suggest to first extend the AST & fix the fuzzer bugs. Once that is done, my tentative idea is to refactor switch to a much more Rusty trait-driven system such as the one we use in [diesel](https://github.com/diesel-rs/diesel) for the backends. I suggest as you proposed to open a [discussion](https://github.com/apache/datafusion-sqlparser-rs/discussions) where to put down the details of the matters and in particular how to deal with the many corner cases which make trivial approaches non generalizable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
