erikbogado-nstech commented on issue #7224: URL: https://github.com/apache/datafusion-comet/issues/7224#issuecomment-6750654118
I'm taking this one. Plan: keep arrow's `Tz` (minute precision) and carry the sub-minute part separately. `extract_offset_suffix` returns the zone plus a residual in seconds, and the parser subtracts the residual from the parsed instant, so `+08:00:30` lands on the same instant Spark computes. `parse_sign_offset` also gains the `+HH:MM:SS` and `+HHMMSS` forms that `ZoneOffset.of` accepts, including the 18:00 cap. TIMESTAMP_NTZ strips the zone as before, so it starts parsing these values too instead of returning NULL. Tests: parser cases for `+08:00:30`, `-01:30:15`, the six-digit form, and the NTZ case, plus the rejected forms (`+08:00:60`, `+18:00:01`, trailing colon). PR to follow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
