andygrove opened a new pull request, #2900: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2900
<!-- comma separated, or `none` --> Dialects: Hive, Databricks Add `Dialect::parse_create_function` and `Dialect::parse_use`, following the existing `parse_statement` hook, and move the Hive and Databricks branches of those rules behind them. Hive's `CREATE FUNCTION` parser moves to `dialect/hive.rs`. Both hooks default to `None`, so other dialects keep using the core rule. Unlike `dialect_of!`, custom dialects can override them, and there are tests for that in `sqlparser_custom_dialect.rs`. This is a small first step towards moving dialect-specific logic out of `Parser` and into the dialects, from the discussion in #2893. I'd like feedback on the direction before going further. One behavior change: a custom dialect that only overrides `dialect()` to act as Hive or Databricks now also has to forward these hooks. `derive_dialect!` forwards them, so a dialect derived from Hive or Databricks gets this behavior even without `preserve_type_id`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
