ump45nose commented on code in PR #2891:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2891#discussion_r4520204599
##########
.github/workflows/labeler.yml:
##########
@@ -17,28 +17,46 @@
name: labeler
-# pull_request_target runs on the base branch, so the script below is never
taken from the PR head.
+# `pull_request_target` is disabled by ASF infra policy. The pull request path
+# runs from the default branch when `pull_request_signal.yml` starts, so it
+# never runs pull request code. See that file for details.
+#
+# `issues` and `issue_comment` already run from the default branch and are
+# unchanged.
+concurrency:
+ group: ${{ github.repository }}-${{
github.event.workflow_run.head_repository.full_name ||
github.event.issue.number }}-${{ github.event.workflow_run.head_branch ||
github.event_name }}-${{ github.workflow }}
Review Comment:
Thanks @LucaCappelletti94 — that cancellation was a real regression against
`main`.
Pushed 17bc5a5 with your suggested group: `workflow_run` stays keyed by the
head repository and branch, and `issues` / `issue_comment` now use
`github.run_id` so a later comment cannot cancel an in-progress labeling run.
(AI-assisted reply.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
