abstractdog commented on PR #2828: URL: https://github.com/apache/datafusion-ballista/pull/2828#issuecomment-6763595518
> Thanks @abstractdog, I agree this error should not break query execution. > > If `update_task_metrics` is changed, we should probably make public `try_update_task_metrics` as well. Handling error at the three call sites will delay api change for now, until we get to bottom of actual issue > > I would suggest instead of changing the API just yet, just check for errors in three call sites. ack, done: `update_task_metrics` is now unchanged, and the three call sites now log a warning instead of propagating -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
