dwsmith1983 commented on PR #27285: URL: https://github.com/apache/datafusion/pull/27285#issuecomment-6768215329
Thanks @Phoenix500526, looks good to me. `left_values` is already evaluated from the concatenated batch right above the call, and checking the evaluated key's type is the same test `is_perfect_hash_join_candidate` ran on the expression, so behavior stays the same while the extra key evaluation goes away. Nice to lose the `too_many_arguments` expect as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
