milenkovicm commented on code in PR #2832:
URL:
https://github.com/apache/datafusion-ballista/pull/2832#discussion_r4526235045
##########
python/python/tests/test_client.py:
##########
@@ -103,17 +104,43 @@ def test_set_ballista_config_reaches_scheduler(address,
pull):
assert status.job_name == "set_reaches_scheduler"
-def test_session_config_configures_default_client(address):
- ctx = BallistaPythonSessionContext(address,
config={"ballista.client.pull": False})
+def test_session_context_without_client_uses_native_client(address):
+ client = RecordingClient(address)
+ ctx = BallistaSessionContext(address)
+ ctx.register_csv("t", TEST_CSV)
+
+ assert ctx.sql("SELECT count(*) AS c FROM t").to_pydict() == {"c": [5]}
+ assert client.jobs == []
Review Comment:
removing this whole test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
