Rachelint commented on issue #12335: URL: https://github.com/apache/datafusion/issues/12335#issuecomment-2353434433
> This would be a valuable improvement. Now the execution behavior is determined by `AggregateMode` + other more subtle inner states like `spill_state.xxx`, and some functions will handle several less related paths at the same time, it's a good idea to separate them (or at least add more doc) However if it's a big refactor, it's better to wait until #11943 gets merged to avoid conflicts I think at least we should separate partial and the teminals(Final, Single...). I am making a poc trying to improve the performance of partial, and I found it is too hard to make it, because all modes are mixed up... I am worried that it will become unmaintainable in future... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
