ump45nose commented on PR #2816: URL: https://github.com/apache/datafusion-ballista/pull/2816#issuecomment-6771774337
Thanks @andygrove — addressed in 64f7275, and I merged current `main` (including the Python Release fix from #2829) so the unrelated `test_typed_setters` failures should clear after CI reruns. - Shared helper: `tcp_incoming_from_listener` in `ballista_core::utils` is used by both `create_grpc_server_incoming` and the standalone scheduler. - `0` disables keepalive everywhere those server paths set it (`tcp_incoming_from_listener`, `create_grpc_server`, and the scheduler `tap_io` path), via one `tcp_keepalive` conversion. Locally, with `protoc` available: - `cargo test -p ballista-core --lib test_tcp_keepalive_zero_disables test_create_grpc_server_incoming_binds_eagerly test_create_grpc_server_incoming_port_in_use` (3 passed) - `cargo test -p ballista-scheduler --lib configures_nodelay_and_keepalive_on_accepted_connections` (1 passed) - `rustfmt` on the three changed files (AI-assisted reply.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
