mkleen commented on PR #26000: URL: https://github.com/apache/datafusion/pull/26000#issuecomment-6776516266
> @mkleen one question for you: with a memory limit and spilling on, this setting never lowered the limit a query needed in my runs, and at 4 target partitions it raised it 4–12x (numbers in the `config.rs` comment). It only lowers peak memory when no limit is set. Is that still the case you want the setting for? @jayzhan211 Yes, the idea was have an option to prefer memory-consumption-over-performance without setting a memory-limit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
