0lai0 commented on code in PR #5300:
URL: https://github.com/apache/datafusion-comet/pull/5300#discussion_r4530938574
##########
native/spark-expr/benches/array_size.rs:
##########
@@ -145,11 +145,20 @@ fn criterion_benchmark(c: &mut Criterion) {
&create_list_array(rows, 5, false),
);
- // LargeList: exposes the Int64 length -> Int32 cast (extra allocation) on
top of
- // the length kernel.
+ // LargeList: builds Int32 lengths from i64 offsets (see
spark_size_large_list_from_offsets).
+ // Shapes mirror List coverage (short/long + 10% null, short + no nulls).
bench(
"spark_size: LargeList (10% null)",
- &create_large_list_array(rows, 5),
+ &create_large_list_array(rows, 5, true),
+ );
+ bench(
+ "spark_size: LargeList of long arrays",
+ &create_large_list_array(rows, 64, true),
+ );
+ // No-null LargeList: production path after CometSize's isnotnull filter.
Review Comment:
Thanks @comphead , updated the comment to the suggested wording.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
