eejbyfeldt commented on code in PR #12458:
URL: https://github.com/apache/datafusion/pull/12458#discussion_r1761592076
##########
datafusion/optimizer/src/eliminate_cross_join.rs:
##########
@@ -96,6 +96,7 @@ impl OptimizerRule for EliminateCrossJoin {
filter.input.as_ref(),
LogicalPlan::Join(Join {
join_type: JoinType::Inner,
+ null_equals_null: false,
Review Comment:
Yes, seems like we should probably unify that logic before making this
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
