comphead commented on code in PR #7595:
URL: https://github.com/apache/datafusion-comet/pull/7595#discussion_r4532818801
##########
spark/pom.xml:
##########
@@ -453,7 +453,7 @@ under the License.
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk18on</artifactId>
- <version>1.78.1</version>
+ <version>1.85</version>
Review Comment:
The comment above this dependency says "The version is the one Hadoop 3.4.1
builds with". That is 1.78.1 (`bouncycastle.version` in
`hadoop-project-3.4.1.pom`), so with this bump the comment no longer holds.
Could a maintainer either drop that sentence along with the bump, or keep the
pin and ignore this update with `@dependabot ignore this dependency`? The jar
only has to provide the class that Hadoop 3.4.1's `KeyProvider` links against,
so either version should work for `CometIcebergHdfsSuite`, though I have not
run it with 1.85.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
