rluvaton commented on code in PR #27302:
URL: https://github.com/apache/datafusion/pull/27302#discussion_r4535803830
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -1319,6 +1439,20 @@ fn check_short_circuit(lhs: &ColumnarValue, op:
&Operator) -> ShortCircuitStrate
ShortCircuitStrategy::None
}
+/// The rows to retry the RHS of `OR` on after it failed on the whole batch:
+/// the rows the LHS did not decide, if it decided any.
+fn or_rows_to_retry(lhs: &ColumnarValue, op: &Operator) ->
Option<BooleanArray> {
+ if *op != Operator::Or || lhs.data_type() != DataType::Boolean {
+ return None;
+ }
+ let ColumnarValue::Array(array) = lhs else {
Review Comment:
added assertion for getting true and comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
