alamb commented on code in PR #12471:
URL: https://github.com/apache/datafusion/pull/12471#discussion_r1761644063
##########
datafusion/core/tests/sql/path_partition.rs:
##########
@@ -491,7 +491,22 @@ async fn parquet_statistics() -> Result<()> {
// stats for the first col are read from the parquet file
assert_eq!(stat_cols[0].null_count, Precision::Exact(1));
// TODO assert partition column stats once implemented (#1186)
- assert_eq!(stat_cols[1], ColumnStatistics::new_unknown(),);
+ assert_eq!(stat_cols[1], ColumnStatistics::new_unknown());
+
+ //// WITH Filter PushDown to [`ParquetExec`] ////
Review Comment:
💯 for the test, but it seems somewhat out of place in
datafusion/core/tests/sql/path_partition.rs (which is testing partitioned files
but this code is relevant to all)
Perhaps we could make a new test that just focused on the statistics for
`ParquetExec` with pushdown filters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
