LucaCappelletti94 commented on PR #2901: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2901#issuecomment-6792024859
The fact that we find ourselves continuously extend the `Dialect` trait makes me ever more convinced that the transposed version with a `Statement` trait with associated to it the parser & dialects for which it works might be much cleaner, and avoid the bloating of `if dialect.supports_this_and_that`. What do you reckon? That aside, the PR direction looks good for the current crate approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
