dwsmith1983 commented on issue #7573: URL: https://github.com/apache/datafusion-comet/issues/7573#issuecomment-6795721430
Before writing the integration, I'd like agreement on two points. 1. Comet has no hook for an expression class that only a contrib knows about. I'd add a `CometExpressionContrib` ServiceLoader interface next to `CometScanContrib`, which the Delta contrib uses to register a serde for `InterleaveBits`, so core still names no Delta class. The other option is matching the class name in core, the way `icebergFunctions.scala` handles Iceberg. 2. The plan is a native Rust kernel, checked against both of Delta's code paths. Routing the expression through the JVM codegen dispatcher would also stop the fallback with no Rust, but it runs Delta's own `eval` rather than a native kernel. @andygrove @comphead does the interface work for you, and is a native kernel what you'd want here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
