Awesome06 commented on code in PR #27258:
URL: https://github.com/apache/datafusion/pull/27258#discussion_r4539614733
##########
datafusion/physical-plan/src/joins/key_range_bitmap.rs:
##########
@@ -16,7 +16,7 @@ use crate::joins::array_map::ArrayMap;
const MAX_BUCKETS: u64 = 1 << 20;
/// One build partition's contribution to [`KeyRangeBitmap::union`].
-pub(crate) enum KeyRangePart<'a> {
+pub enum KeyRangePart<'a> {
Review Comment:
Marked `KeyRangePart` with `#[doc(hidden)]` and added the internal use note
per `api-health.md`.
##########
datafusion/physical-plan/src/joins/key_range_bitmap.rs:
##########
@@ -107,7 +107,7 @@ impl KeyRangeBitmap {
/// Coarser than the parts' own bitmaps where its buckets are wider, but
/// never clears a bucket a part may hold a key in. `None` when the key
/// type has no `u64` ordering, or when nothing can be excluded.
- pub(crate) fn union(
+ pub fn union(
Review Comment:
Updated `union` with `#[doc(hidden)]` and the internal use note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
