alamb commented on code in PR #25811:
URL: https://github.com/apache/datafusion/pull/25811#discussion_r4540160625
##########
datafusion/core/tests/parquet/io/bloom_filter_io.rs:
##########
@@ -66,10 +66,8 @@ async fn test_parquet_bloom_filter_io_matching() {
#[tokio::test]
async fn test_parquet_bloom_filter_io_pruned() {
let test = bloom_filter_test().await;
- // Currently the Bloom filters for all candidate columns (`a` and `b`) are
- // loaded upfront. With incremental pruning
- // (https://github.com/apache/datafusion/issues/25811), `a` would be
- // evaluated first and the Bloom filter for `b` would not be loaded.
+ // Column `a` does not match, so the row group is pruned immediately
Review Comment:
I am surprised that there are no other changes -- I would think we should
have a test showing that this change now effectively interleaves IO and compute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
