cblp opened a new pull request, #27336:
URL: https://github.com/apache/datafusion/pull/27336

   ## Which issue does this PR close?
   
   - Part of #27239.
   
   ## Rationale for this change
   
   Error checks that put the full message on the `query error` line as an 
escaped regex are hard to read and review. Plain text after `----` is exact and 
readable.
   
   ## What changes are included in this PR?
   
   Converts the 20 full-message escaped-regex error checks in 5 files, as 
claimed in 
https://github.com/apache/datafusion/issues/27239#issuecomment-6803115271:
   
   - `datetime/date_part.slt` (11)
   - `datetime/interval.slt` (6)
   - `datetime/dates.slt` (1)
   - `datetime/interval_mysql.slt` (1)
   - `datetime/arith_interval_double.slt` (1)
   
   Each new message equals the old regex with the escapes removed. Checks that 
match only part of a message (not starting with `DataFusion error:`) are left 
as they are. `datetime/timestamps.slt` is not included.
   
   Note: #27263 converts all 65 files in one PR and overlaps with these files.
   
   ## What is the testing strategy for this PR?
   
   Test-only change. The expected messages were generated with `--complete` and 
compared against the old regexes; `cargo test --test sqllogictests -- 
datetime/` passes.
   
   ## Are there any user-facing changes?
   
   No.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to