raghavyadav01 commented on PR #26904: URL: https://github.com/apache/datafusion/pull/26904#issuecomment-6805194497
Re-ran all 57 queries in DuckDB 1.5.6. Every expected answer in the comments matches, the 11 recorded as right match too, and the 4 error cases also fail in DuckDB. One small thing: `invalid_aggregate_over_outer_column_without_from` and `invalid_aggregate_over_outer_column_in_having` have no comment, so a later PR that makes them return rows would look like a fix. Maybe add one like the others: ``` # Should fail while planning: the aggregate belongs to the outer query. # DuckDB: Binder Error: column "t1_int" must appear in the GROUP BY clause or must be part of an aggregate function. ``` (the HAVING one gives `Binder Error: WHERE clause cannot contain aggregates!`) Otherwise looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
