devanbenz commented on code in PR #12466:
URL: https://github.com/apache/datafusion/pull/12466#discussion_r1761713102


##########
datafusion/sql/src/statement.rs:
##########
@@ -1028,8 +1030,26 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
             .into_iter()
             .collect();
 
-        let schema = self.build_schema(columns)?;
-        let df_schema = schema.to_dfschema_ref()?;
+        let df_schema = match file_type.as_str() {

Review Comment:
   > I am sorry for the delayed feeback @devanbenz -- I swear I typed this 
feedback but i must not have clicked "submit"
   
   Thats alright -happens to me all the time 😅 
   
   > Perhaps you could delay the creation of the ORDER BY until the table 
provider is resolved?
   
   Sounds good, I like this idea. 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to