andygrove commented on PR #6726: URL: https://github.com/apache/datafusion-comet/pull/6726#issuecomment-6805899356
Thanks @viirya and @comphead. `CometInMemoryCacheSuite` now expects a conversion for `array of int`. Neither of the two replacements suggested worked as the case that stays on Spark's transition. `RowToColumnarExec` itself throws `UNSUPPORTED_DATATYPE` for a collated string and for `NullType`, and a day-time interval gets no transition at all, because the cache serializer has no arm for it. An empty struct is the case that works: the serializer takes it, Spark's transition converts it, and the conversion still declines it. I merged `main` (35a2d3bd38) and `CometInMemoryCacheSuite`, `CometShuffleInputConversionSuite` and the `SparkToColumnar` tests in `CometExecSuite` pass on Spark 4.1. `test-compile -Pspark-3.5 -Pstrict-warnings` passes too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
