andygrove opened a new pull request, #54:
URL: https://github.com/apache/datafusion-spark/pull/54

   ## Rationale for this change
   
   The expected results in the `.slt` files under 
`crates/sqllogictest/test_files` come from DataFusion, and nothing checks them 
against Spark. Running some of these files on a local Spark has already found 
wrong expectations, but everyone who does that has to build their own harness. 
This adds one as a manual tool, so anyone with Python and Java can check one 
file, or the whole directory, against Spark 4.2.
   
   This is a port of apache/datafusion#27165 to this repository.
   
   ## What changes are included in this PR?
   
   - `crates/spark/scripts/pyspark_slt_runner.py` runs each record on a local 
PySpark 4.2 session and reports records where Spark returns different rows, 
raises an unexpected error (or doesn't raise an expected one), returns a 
different column type, prints the same numbers at a different scale, or returns 
rows in a different order. Records Spark cannot parse or lacks functions for 
are skipped and counted.
   - A README with setup and usage, linked from the sqllogictest README.
   - Unit tests that need neither Spark nor Java.
   - `__pycache__/` in a new `.gitignore`.
   
   Nothing runs in CI.
   
   ## Are these changes tested?
   
   Unit tests: `python3 -m unittest discover -s crates/spark/scripts` (37 
pass). The runner itself was not run against Spark from this repository's 
layout.
   
   ## Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to